Skip to content

Revert "[enhancement](hive)Initial support for Hive org.openx.data.jsonserde.JsonSerDe"#49928

Merged
hello-stephen merged 1 commit intomasterfrom
revert-49209-openx_json_serde
Apr 10, 2025
Merged

Revert "[enhancement](hive)Initial support for Hive org.openx.data.jsonserde.JsonSerDe"#49928
hello-stephen merged 1 commit intomasterfrom
revert-49209-openx_json_serde

Conversation

@hello-stephen
Copy link
Contributor

@hello-stephen hello-stephen commented Apr 9, 2025

Reverts #49209

@Thearas
Copy link
Contributor

Thearas commented Apr 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor Author

hello-stephen commented Apr 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.06% (18160/27489)
Region Coverage: 65.50% (8946/13657)
Branch Coverage: 55.39% (4823/8708)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fe360406226407cf7e96927754ae9c9e143a55e1_fe360406226407cf7e96927754ae9c9e143a55e1_cloud/report/index.html

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-H: Total hot run time: 34517 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe360406226407cf7e96927754ae9c9e143a55e1, data reload: false

------ Round 1 ----------------------------------
q1	26085	5120	5054	5054
q2	2068	313	191	191
q3	10698	1282	713	713
q4	10322	1027	527	527
q5	8927	2412	2410	2410
q6	185	163	133	133
q7	901	743	643	643
q8	9339	1311	1117	1117
q9	6832	5117	5149	5117
q10	6830	2310	1911	1911
q11	485	291	278	278
q12	345	360	222	222
q13	17777	3703	3169	3169
q14	234	236	204	204
q15	533	486	477	477
q16	624	630	566	566
q17	635	880	388	388
q18	7883	7346	7130	7130
q19	1872	967	554	554
q20	339	346	232	232
q21	4303	3481	2540	2540
q22	1058	1017	941	941
Total cold run time: 118275 ms
Total hot run time: 34517 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5134	5148	5121	5121
q2	244	332	233	233
q3	2182	2682	2274	2274
q4	1542	1896	1475	1475
q5	4590	4442	4319	4319
q6	210	169	125	125
q7	1931	1891	1812	1812
q8	2638	2664	2541	2541
q9	7200	7162	7216	7162
q10	2995	3184	2756	2756
q11	579	503	502	502
q12	664	781	590	590
q13	3553	3863	3368	3368
q14	282	305	283	283
q15	521	478	484	478
q16	628	696	643	643
q17	1159	1525	1441	1441
q18	7719	7387	7550	7387
q19	814	802	840	802
q20	1979	2033	1878	1878
q21	5249	4662	4767	4662
q22	1068	1018	1010	1010
Total cold run time: 52881 ms
Total hot run time: 50862 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-DS: Total hot run time: 187296 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe360406226407cf7e96927754ae9c9e143a55e1, data reload: false

query1	1044	485	475	475
query2	6557	1969	1961	1961
query3	6762	229	220	220
query4	25472	23548	23568	23548
query5	4381	646	482	482
query6	306	204	195	195
query7	4630	491	280	280
query8	301	246	238	238
query9	8612	2603	2590	2590
query10	514	321	262	262
query11	15785	15398	15034	15034
query12	175	111	105	105
query13	1652	515	401	401
query14	9738	6268	6377	6268
query15	204	193	172	172
query16	7621	614	485	485
query17	1194	732	583	583
query18	2024	412	312	312
query19	195	182	161	161
query20	120	117	124	117
query21	213	134	112	112
query22	4189	4111	3982	3982
query23	33885	33078	33042	33042
query24	8398	2403	2402	2402
query25	539	447	384	384
query26	1239	273	147	147
query27	2752	508	330	330
query28	4302	2436	2385	2385
query29	705	550	429	429
query30	289	220	197	197
query31	927	880	778	778
query32	70	66	67	66
query33	589	364	321	321
query34	813	862	517	517
query35	785	827	755	755
query36	953	1019	898	898
query37	122	103	77	77
query38	4176	4326	4123	4123
query39	1470	1415	1410	1410
query40	216	121	112	112
query41	55	55	55	55
query42	119	108	101	101
query43	487	519	456	456
query44	1321	815	814	814
query45	184	177	174	174
query46	840	1010	618	618
query47	1750	1817	1716	1716
query48	384	410	309	309
query49	778	565	428	428
query50	629	692	390	390
query51	4157	4144	4221	4144
query52	110	110	100	100
query53	231	259	188	188
query54	568	573	510	510
query55	86	79	86	79
query56	294	289	288	288
query57	1126	1154	1079	1079
query58	283	261	257	257
query59	2668	2755	2574	2574
query60	333	327	316	316
query61	130	129	127	127
query62	776	713	673	673
query63	230	184	193	184
query64	4304	1031	700	700
query65	4399	4246	4236	4236
query66	1083	411	310	310
query67	15659	15649	15373	15373
query68	8510	883	518	518
query69	466	306	264	264
query70	1196	1142	1103	1103
query71	455	332	294	294
query72	5365	4771	4667	4667
query73	720	589	339	339
query74	9212	9112	8907	8907
query75	3983	3227	2721	2721
query76	3714	1185	763	763
query77	789	378	291	291
query78	10024	10264	9253	9253
query79	1526	827	562	562
query80	606	525	439	439
query81	489	258	224	224
query82	226	128	95	95
query83	307	262	245	245
query84	289	103	82	82
query85	800	364	322	322
query86	334	300	275	275
query87	4647	4515	4397	4397
query88	2883	2269	2231	2231
query89	388	317	285	285
query90	2110	215	226	215
query91	145	143	111	111
query92	83	61	60	60
query93	1113	965	593	593
query94	671	398	291	291
query95	380	300	290	290
query96	494	561	276	276
query97	3161	3266	3125	3125
query98	225	208	209	208
query99	1432	1436	1295	1295
Total cold run time: 273646 ms
Total hot run time: 187296 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

ClickBench: Total hot run time: 30.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe360406226407cf7e96927754ae9c9e143a55e1, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.19
query4	1.59	0.19	0.20
query5	0.55	0.55	0.56
query6	1.20	0.72	0.72
query7	0.03	0.01	0.01
query8	0.04	0.04	0.03
query9	0.58	0.52	0.51
query10	0.59	0.59	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.61
query14	2.66	2.83	2.67
query15	0.95	0.87	0.85
query16	0.39	0.37	0.39
query17	1.02	1.03	1.04
query18	0.22	0.20	0.20
query19	1.99	1.84	1.83
query20	0.01	0.01	0.01
query21	15.35	0.88	0.55
query22	0.75	1.23	0.62
query23	14.92	1.41	0.60
query24	6.87	2.22	0.45
query25	0.44	0.12	0.14
query26	0.71	0.17	0.14
query27	0.05	0.05	0.05
query28	9.34	0.91	0.44
query29	12.61	4.05	3.37
query30	0.25	0.10	0.07
query31	2.80	0.59	0.40
query32	3.22	0.55	0.47
query33	3.01	3.02	3.07
query34	15.67	5.15	4.54
query35	4.50	4.52	4.47
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 104.81 s
Total hot run time: 30.81 s

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.34% (14069/26879)
Line Coverage 41.13% (121532/295498)
Region Coverage 39.85% (61830/155158)
Branch Coverage 34.50% (30947/89700)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit fa51185 into master Apr 10, 2025
28 of 32 checks passed
hubgeter added a commit to hubgeter/doris that referenced this pull request Apr 10, 2025
@hubgeter
Reapply "[enhancement](hive)Initial support for Hive org.openx.data.j…
129657f 
…sonserde.JsonSerDe" (apache#49928)

This reverts commit fa51185.
hubgeter added a commit to hubgeter/doris that referenced this pull request Apr 11, 2025
@hubgeter
Reapply "[enhancement](hive)Initial support for Hive org.openx.data.j…
2ea63cd 
…sonserde.JsonSerDe" (apache#49928)

This reverts commit fa51185.
morningman pushed a commit to hubgeter/doris that referenced this pull request Apr 14, 2025
@hubgeter @morningman
Reapply "[enhancement](hive)Initial support for Hive org.openx.data.j…
edd676a 
…sonserde.JsonSerDe" (apache#49928)

This reverts commit fa51185.
morningman pushed a commit that referenced this pull request Apr 18, 2025
@hubgeter
Reapply "[enhancement](hive)Initial support for Hive org.openx.data.j…
0d09cfe 
…sonserde.JsonSerDe" (#49928) (#49958)

This reverts commit fa51185.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@hello-stephen
Revert "[enhancement](hive)Initial support for Hive org.openx.data.js…
0839a91 
…onserde.JsonSerDe" (apache#49928)

Reverts apache#49209
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@hubgeter
Reapply "[enhancement](hive)Initial support for Hive org.openx.data.j…
bd3ba9b 
…sonserde.JsonSerDe" (apache#49928) (apache#49958)

This reverts commit fa51185.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @Thearas @doris-robot @morningman @zclllyybb